Migrate core/options.js to goog.module syntax #5287
Merged
moniika merged 6 commits intoRaspberryPiFoundation:goog_modulefrom Aug 5, 2021
Merged
Migrate core/options.js to goog.module syntax #5287moniika merged 6 commits intoRaspberryPiFoundation:goog_modulefrom
moniika merged 6 commits intoRaspberryPiFoundation:goog_modulefrom
Conversation
added 5 commits
August 2, 2021 16:00
moniika
force-pushed
the
convert-options
branch
from
ee17b3e to
4009d55
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm testlocally already.The details
Resolves
Part of #5026
Proposed Changes
Converts
core/options.jstogoog.modulesyntax.Additional Information
This PR also refactors
Blockly.BlocklyOptionsour ofBlockly.Optionsinto a separate module incore/blockly_options.jsand adds missing requires to files that useBlockly.BlocklyOptions.In some cases, unused
Blocklyrequires were removed (under the assumption that they were added by mistake thinking they were needed forBlockly.BlocklyOptions